Fix browser SyntaxError on the SSE [DONE] sentinel - #2
Merged
Conversation
The stream ends with `data: [DONE]`, which is not JSON. The page fed every data line to JSON.parse, so the sentinel threw "Unexpected token 'D'" and the caught error was painted red under an otherwise complete answer. Skip the [DONE] line (and any empty data line) before parsing.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stream ends with
data: [DONE], which is not JSON. The page fed every data line toJSON.parse, so the sentinel threw "Unexpected token 'D'" and the caught error was painted red under an otherwise complete answer. The fix skips the[DONE]line (and any empty data line) before parsing. Adds a regression test; full suite 60 passing. Verified live on device.